[Bug 581279] Review Request: erlang-ibrowse - Erlang HTTP client

Wed May 26 15:58:21 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=581279

David Cantrell <dcantrell at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |needinfo?(lemenkov at gmail.co
                   |                            |m)

--- Comment #4 from David Cantrell <dcantrell at redhat.com> 2010-05-26 11:58:18 EDT ---
[+] PASS    [-] FAIL   [N/A] Not Applicable

-  MUST: rpmlint must be run on every package. The output should be posted in
the review.

$ rpmlint erlang-ibrowse-1.5.6-2.fc13.src.rpm 
erlang-ibrowse.src: W: invalid-url Source0: erlang-ibrowse-1.5.6.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

The Source0 line needs to use the %{alphatag} naming format since you are
pulling from git.  I see you're pulling from a git commit, but if there's a tag
for the 1.5.6 release, that might be better to use.
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages

+ MUST: The package must be named according to the Package Naming Guidelines.

+ MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.

+ MUST: The package must meet the Packaging Guidelines.

+ MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.

- MUST: The License field in the package spec file must match the actual
license.

The License field indicates 'BSD or LGPLv2' but it should be 'BSD and LGPLv2'.

+ MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.

+ MUST: The spec file must be written in American English.

- MUST: The spec file for the package MUST be legible.

These are really just my own opinion.  In general I think the spec file is
perfectly legible, but since we are in review, I figured I'd point out these
things:

1) The Requires: lines do not use a tab character to indent the value to the
16th column like the Name through BuildRequires lines.

2) The iconv line in the %prep section is long.  I would suggest breaking up
the line because the spill over on an 80 column terminal makes the "rm -f
README.utf8" appear to be its own line, when really it's part of the entire
iconv line.

+ MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

+ MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.

$ koji build --scratch dist-f13 erlang-ibrowse-1.5.6-2.fc13.src.rpm 
Uploading srpm: erlang-ibrowse-1.5.6-2.fc13.src.rpm
[====================================] 100% 00:00:01  40.06 KiB  22.30 KiB/sec
Created task: 2211092
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2211092
None
Watching tasks (this may be safely interrupted)...
2211092 build (dist-f13, erlang-ibrowse-1.5.6-2.fc13.src.rpm): free
2211092 build (dist-f13, erlang-ibrowse-1.5.6-2.fc13.src.rpm): free -> open
(ppc04.phx2.fedoraproject.org)
  2211094 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, i686): free
  2211093 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, x86_64): free
  2211093 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, x86_64): free -> open
(x86-09.phx2.fedoraproject.org)
  2211094 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, i686): free -> open
(x86-04.phx2.fedoraproject.org)
  2211094 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, i686): open
(x86-04.phx2.fedoraproject.org) -> closed
  0 free  2 open  1 done  0 failed
  2211093 buildArch (erlang-ibrowse-1.5.6-2.fc13.src.rpm, x86_64): open
(x86-09.phx2.fedoraproject.org) -> closed
  0 free  1 open  2 done  0 failed
2211092 build (dist-f13, erlang-ibrowse-1.5.6-2.fc13.src.rpm): open
(ppc04.phx2.fedoraproject.org) -> closed
  0 free  0 open  3 done  0 failed

2211092 build (dist-f13, erlang-ibrowse-1.5.6-2.fc13.src.rpm) completed
successfully

N/A MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.

+ MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

N/A MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

N/A MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.

+ MUST: Packages must NOT bundle copies of system libraries.

N/A MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.

+ MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.

+ MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.

+ MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.

+ MUST: Each package must consistently use macros.

+ MUST: The package must contain code, or permissable content.

N/A MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).

+ MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.

N/A MUST: Header files must be in a -devel package.

N/A MUST: Static libraries must be in a -static package.

N/A MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.

N/A MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}

N/A MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.

N/A MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.

+ MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.

+ MUST: All filenames in rpm packages must be valid UTF-8.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.