[Bug 593841] Review Request: wicd - Wireless and wired network connection manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593841

--- Comment #16 from David Cantrell <dcantrell at redhat.com> 2010-05-27 00:16:47 EDT ---
(In reply to comment #14)
> wicd.x86_64: E: explicit-lib-dependency dbus-glib

Fixed.

> wicd.x86_64: E: no-binary
> wicd.x86_64: W: only-non-binary-in-usr-lib

This can't change as the only arch-dependent component of wicd at the moment is
the pm-utils script.  And since the pm-utils package is arch-dependent, this
package has to be.

> wicd.x86_64: W: no-documentation

Fixed.

> [leigh at localhost Desktop]$ rpmlint
> /home/leigh/rpmbuild/RPMS/noarch/wicd-common-1.7.0-1.fc13.noarch.rpm
> wicd-common.noarch: W: spelling-error %description -l en_US frontend ->
> fronted, front end, front-end

Fixed.

> wicd-common.noarch: E: executable-marked-as-config-file
> /etc/acpi/suspend.d/50-wicd-suspend.sh

Fixed.

> wicd-common.noarch: E: non-executable-script /usr/share/wicd/cli/wicd-cli.py
> 0644L /usr/bin/python
> wicd-common.noarch: E: non-executable-script
> /usr/share/wicd/daemon/wicd-daemon.py 0644L /usr/bin/env
> wicd-common.noarch: E: non-executable-script
> /usr/share/wicd/backends/be-external.py 0644L /usr/bin/env
> wicd-common.noarch: E: non-executable-script
> /usr/share/wicd/backends/be-ioctl.py 0644L /usr/bin/env
> wicd-common.noarch: E: non-executable-script

Fixed.

> /usr/lib/python2.6/site-packages/wicd/logfile.py 0644L /usr/bin/python
> wicd-common.noarch: E: wrong-script-end-of-line-encoding

Fixed.

> /usr/lib/python2.6/site-packages/wicd/logfile.py
> wicd-common.noarch: E: executable-marked-as-config-file
> /etc/acpi/resume.d/80-wicd-connect.sh

Fixed.

> wicd-common.noarch: W: log-files-without-logrotate /var/log/wicd

Fixed, but now rpmlint complains because the logrotate file is
/etc/logrotate.d/wicd instead of /etc/logrotate.d/wicd-common.  Given that the
service name is 'wicd' and the log file will be /var/log/wicd.log, I figured
this is a better logrotate file name than wicd-common.  I could move the
logrotate component to the wicd package to suppress this message, let me know.

> wicd-common.noarch: E: init-script-without-chkconfig-postin
> /etc/rc.d/init.d/wicd
> wicd-common.noarch: E: init-script-without-chkconfig-preun
> /etc/rc.d/init.d/wicd

Fixed.

> wicd-common.noarch: W: incoherent-init-script-name wicd ('wicd-common',
> 'wicd-commond')

This one should be ignored as the service name is wicd, but since it's in the
group of noarch files, I put it in the wicd-common package.  I could move it to
the wicd package, but then it would sit alone without the rest of the Python
code.  I suppose I don't mind either way, just let me know.

> wicd-curses.noarch: E: non-executable-script
> /usr/share/wicd/curses/curses_misc.py 0644L /usr/bin/env
> wicd-curses.noarch: E: non-executable-script
> /usr/share/wicd/curses/netentry_curses.py 0644L /usr/bin/env
> wicd-curses.noarch: E: non-executable-script
> /usr/share/wicd/curses/prefs_curses.py 0644L /usr/bin/env

Fixed.

> /home/leigh/rpmbuild/RPMS/noarch/wicd-gtk-1.7.0-1.fc13.noarch.rpm
> wicd-gtk.noarch: W: no-documentation

The documentation is in the main wicd package.

> wicd-gtk.noarch: E: non-executable-script /usr/share/wicd/gtk/prefs.py 0644L
> /usr/bin/python

Fixed.

> wicd-gtk.noarch: W: non-conffile-in-etc /etc/xdg/autostart/wicd-tray.desktop

I think this is ok.  NetworkManager's spec file lists:

    %{_sysconfdir}/xdg/autostart/nm-applet.desktop

If I need to mark it as a config file, let me know.

> wicd-gtk.noarch: E: non-executable-script /usr/share/wicd/gtk/wicd-client.py
> 0644L /usr/bin/env
> wicd-gtk.noarch: E: non-executable-script /usr/share/wicd/gtk/gui.py 0644L
> /usr/bin/python

Fixed.


Thanks for the review feedback!  New spec and srpm:
http://dcantrel.fedorapeople.org/wicd/wicd.spec
http://dcantrel.fedorapeople.org/wicd/wicd-1.7.0-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.