[Bug 590329] Review Request: perl-MooseX-Traits - Automatically apply roles at object creation time

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590329

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2010-05-28 04:49:21 EDT ---
+ source files match upstream.  
    136f624a9d8084a6ef27aad62479d2a6  MooseX-Traits-0.09.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
    GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
- latest version is being packaged.
    0.11 is available now

- BuildRequires are proper.
    missing BR perl(MooseX::Role::Parameterized)

+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2215120

+ package installs properly.
+ rpmlint has no complaints:
    perl-MooseX-Traits.noarch: I: checking
    perl-MooseX-Traits.noarch: I: checking-url
http://search.cpan.org/dist/MooseX-Traits (timeout 10 seconds)
    perl-MooseX-Traits.src: I: checking
    perl-MooseX-Traits.src: I: checking-url
http://search.cpan.org/dist/MooseX-Traits (timeout 10 seconds)
    perl-MooseX-Traits.src: I: checking-url
http://search.cpan.org/CPAN/authors/id/J/JR/JROCKWAY/MooseX-Traits-0.09.tar.gz
(timeout 10 seconds)
    2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
    perl(MooseX::Traits) = 0.09
    perl(MooseX::Traits::Util)  
    perl-MooseX-Traits = 0.09-1.fc14
=
    perl(Carp)  
    perl(Class::MOP) >= 0.84
    perl(:MODULE_COMPAT_5.12.0)  
    perl(Moose::Role)  
    perl(MooseX::Traits::Util)  
    perl(namespace::autoclean)  
    perl(strict)  
    perl(Sub::Exporter)  
    perl(warnings)  
    perl(warnings::register)  

+ %check is present and all tests pass.
    PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t
    t/00-load.t ........ ok
    t/basic.t .......... ok
    t/class.t .......... ok
    t/parameterized.t .. skipped: testing parameterized roles requires
MooseX::Role::Parameterized
    t/subclass.t ....... ok
    t/with-traits.t .... ok
    All tests successful.
    Files=6, Tests=69,  1 wallclock secs ( 0.03 usr  0.00 sys +  1.14 cusr 
0.09 csys =  1.26 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


The only minor problem is a missing BR perl(MooseX::Role::Parameterized) - the
skipped test works for me locally. And there's a newer version available now. 

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.