[Bug 596746] Review Request: bzr-explorer - A bzr GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596746

--- Comment #4 from Julian Aloofi <julian.fedora at googlemail.com> 2010-05-28 07:04:34 EDT ---
(In reply to comment #3)

>  - use version macro in source url
>  - use globbing for egg-info to simplify upgrade?

Right, where were I thinking? :D

>  - don't builds in F12 (missing defs) okay?

bzr-explorer requires bzr 2.1, which isn't in Fedora 12 anyway as far as I can
see ( https://admin.fedoraproject.org/updates/bzr ).
I haven't tried building it on Fedora 12, but I'm trusting upstream on this
one.

>  - summary is a bit short?

It gets found when searching for bzr and GUI and sums it up nicely (well, at
least in my opinion). But Debian's description is "GUI application for using
bazaar", and so is the .desktop's file, so I guess it is a good idea to change
it.

>  - some places you use %{name}, some you don't.

Yeah, I admit I skipped the "find name and version usage and replace" step,
will adjust that now.

> 
> For later reference, koji builds it fine:
> 
>   http://koji.fedoraproject.org/koji/taskinfo?taskID=2214002    

I did a build against dist-f13 as well (as mock was causing some errors)

http://koji.fedoraproject.org/koji/taskinfo?taskID=2212591


So here are the new spec and SRPM:

Spec URL: http://julian.fedorapeople.org/bzr-explorer/bzr-explorer.spec

SRPM URL:
http://julian.fedorapeople.org/bzr-explorer/bzr-explorer-1.0.1-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.