[Bug 581104] Review Request: lv2-EQ10Q-plugins - Parametric equalizer lv2 plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581104

Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

Bug 581104 depends on bug 537363, which changed state.

Bug 537363 Summary: Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
https://bugzilla.redhat.com/show_bug.cgi?id=537363

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|                            |ERRATA

--- Comment #11 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2010-05-31 00:20:05 EDT ---
I made a full review. A few minor things could be added/corrected. Otherwise we
are good to go.

! rpmlint complains about spelling errors. 
   lv2-EQ10Q-plugins.x86_64: W: spelling-error Summary(en_US) diferent ->
different, difference, deferential
   lv2-EQ10Q-plugins.x86_64: W: spelling-error %description -l en_US plugin ->
plug in, plug-in, plugging
   lv2-EQ10Q-plugins.x86_64: W: spelling-error %description -l en_US diferent
-> different, difference, deferential
   lv2-EQ10Q-plugins.x86_64: W: spelling-error %description -l en_US
biquadratic -> bi quadratic, bi-quadratic, quadratic
   lv2-EQ10Q-plugins-debuginfo.x86_64: W: spelling-error Summary(en_US) lv ->
lb, l, v
   lv2-EQ10Q-plugins-debuginfo.x86_64: W: spelling-error %description -l en_US
lv -> lb, l, v

"plug-in" and "different" can be corrected. The rest can be ignored.

? A little explanation on patches would be nice. The patches look quite clean
and portable. Did you contact upstream about these?

! Upstream could be reminded about missing license text files.

* koji rawhide build is fine:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=2218755

- I couldn't do a functionality test yet with the static linkage. I will do
that whenever people are not sleeping :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.