[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597755

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2010-05-31 00:43:41 EDT ---
+ is ok
- Needs work

Review:
+ package builds in mock (rawhide i686).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=2218732

+ rpmlint output for SRPM and for RPM is
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/main.py 0644L /usr/bin/env
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/settings/_version.py 0644L
/usr/bin/env
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/qt4gui/schema_updater.py 0644L
/usr/bin/env
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/firstRun.py 0644L /usr/bin/env
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/createdemodatabase.py 0644L
/usr/bin/env
openmolar.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/openmolar/qt4gui/customwidgets/calendars.py
0644L /usr/bin/env
openmolar.noarch: W: no-manual-page-for-binary openmolar
Each executable in standard binary directories should have a man page.

+ source files match upstream url (sha1sum)
27fff756480eb2072543bf80df8ed2b1d717b08c  openmolar-0.1.9.tar.gz
27fff756480eb2072543bf80df8ed2b1d717b08c  openmolar-0.1.9.tar.gz.srpm
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ Translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ GUI application and Desktop file installed correctly.

Suggestions:
1) If you want either you can ask upstream to include openmolar man page or you
can also write it.
This is not blocker for review but just a suggestion.

2) remove following from %build as there is no compilation happenings that need
RPM_OPT_FLAGS.

CFLAGS="$RPM_OPT_FLAGS" 

3) Add PKG-INFO to %doc

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.