[Bug 612581] Review Request: spacewalk-backend - Common programs needed to be installed on the Spacewalk servers/proxies

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612581

--- Comment #19 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-11-01 11:14:22 EDT ---
(In reply to comment #16)
> 3) /etc/httpd/conf.d - this is only one, which I'm willing to change. Although
> this will make upgrades little bit complicated for us.

What do you mean? It's up to the administrator to make sure new version of
config file uses correct format and has all needed config options (merging
.rpmsave or .rpmnew files as needed depending on use of noreplace). It doesn't
change anything for the packager. You just have to decide if you prefer to
overwrite custom changes or if you take a risk someone uses out-of-date config
files...

(In reply to comment #18)
> > sql subpackage has /usr/share/rhn/server/__init__.py file which is a copy of
> > file in /usr/lib/. This file is needed for some sub-packages to work I guess
> > since some are placing files under /usr/share/rhn/server. Otherwise the dir
> > wouldn't be recognized as python module. Am I correct? In that case please
> > instead of having copy of the file, create a symlink from one to the other.
> Correct. IMO this change will make Makefile more complicated and will make
> maintenance harder, I do no think that saving 730 bytes will justify harder
> maintenance.

I assume you meant it will make spec file more complicated? One way or the
other. FESCO had to give special exception to duplicating LICENSE files when
new guidelines came into play. So non-LICENSE files cannot be duplicated in a
rpm without FESCO exception. This __init__.py will have to be symlinked or
you'll have to ask for exception with FESCO. Sorry I wasn't clear about this in
the original review. (it might be possible I understood the guidelines
wrong...but someone would have to convince me :-) )

> > LICENSE files don't have to be included in every subpackage since they depend
> > on each other.
> I would rather have it there, if it is not problem.

I am not entirely sure this is "clean" since you are duplicating files when
duplication is not needed/required by guidelines. But I asked on fedora-devel
and seems like it would be better not to duplicate these LICENSE files if it's
not required, but it's not against the guidelines either...so up to you.

> > Use grep instead of egrep
> addressed
> 
> > /usr/lib/python2.7/site-packages/spacewalk/wsgi and then populated
> > /usr/share/rhn/wsgi/. I assume this is a mistake?
> addressed

Great

So could you please addess that one file copy (even the LICENSEs if you feel
like it). After that...I believe I'll be able to approve the package with
confidence :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.