[Bug 646836] Review Request: rubygem-bundler - The best way to manage your application's dependencies

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646836

--- Comment #2 from Jozef Zigmund <jzigmund at redhat.com> 2010-11-02 12:17:11 EDT ---
(In reply to comment #1)
> Some notes:
> 
> * ruby(abi) dependency
>   - Writing "Requires: ruby(abi) = 1.8" is a must
>     https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines

+ dependency Requires: ruby(abi) = 1.8

> * Consistent macro usage
>   - As you defined %geminstdir macro, please use this macro also
>     in %files section

+ macro %geminstdir in %files section

> * Document files
>   - Please mark document files as %doc properly.
>     - CHANGELOG.md or so should be marked as %doc
> -------------------------------------------
> CHANGELOG.md
> ISSUES.md
> README.md
> UPGRADING.md
> -------------------------------------------
>     - Also, the following files
> -------------------------------------------
> Rakefile
> bundler.gemspec (under %geminstdir, not the one under specifications/)
> spec/
> -------------------------------------------
>       are not needed on runtime and should be marked as %doc.
>       We usually move these "unneeded" files to -doc subpackage.

+ Add subpackage %files doc with these files, but i'm confused about this line
"bundler.gemspec (under %geminstdir, not the one under specifications/)"
because in http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Gems, is written:

The package must own the following files and directories:
%{gemdir}/gems/%{gemname}-%{version}/
%{gemdir}/cache/%{gemname}-%{version}.gem
%{gemdir}/specifications/%{gemname}-%{version}.gemspec

>     - .gitignore file is not needed and should be removed

+ Removed

> * Shipping external project
>   - This gem bundles external project (for this package thor)
>     under lib/bundler/vendor/. On Fedora shipping external project in
>     the same package should (must) be avioded, see:
>    
> https://fedoraproject.org/wiki/Packaging/Guidelines#Bundling_of_multiple_projects
> 
>     As Fedora already ships rubygem-thor, please remove this vendorlized
>     directory and modify scripts in bundler gem to use rubygem-thor rpm.

+Rubygem-thor has already been in fedora repos, so i removed this vendor
directory and add require of this gem to Requires part.

New SPEC file: http://people.redhat.com/jzigmund/rubygem-bundler.spec
New SRPM file:
http://people.redhat.com/jzigmund/rubygem-bundler-1.0.3-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.