[Bug 648633] Review Request: python-sphinx10 - Python documentation generator

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 2 18:20:33 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648633

--- Comment #8 from Toshio Ernie Kuratomi <a.badger at gmail.com> 2010-11-02 14:20:32 EDT ---
Good:
* Package follows naming guidelines
* Package licensed  appropriately
* Spec file readable
* Sources match upstream
* locales handled correctly
* Not a shared library
* No bundled libraries
* Package owns all directories and files it creates and nothing else
* Permissions set properly
* Macros used consistently.
* code, not content.
* Nothing in %doc affects runtime
* Not a GUI
* All filenames are utf8

Needswork:
* Does not build in koji for EL-5:
http://koji.fedoraproject.org/koji/getfile?taskID=2572200&name=build.log

I'd just disable man page generation on EL-5 I think.  I'll check rpmlint and
that it works properly after that's fixed.  Everything else looks fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list