[Bug 484051] Review Request: sockettest - Test My Socket

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 2 23:30:49 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484051

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(itamar at ispbrasil.
                   |                            |com.br)

--- Comment #13 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-02 19:30:45 EDT ---
This ticket is very confusing.  It doesn't seem that there's been a single
response from the original submitter, which is unfortunate because it seems at
least one other person wants to submit this.  I guess what I'll do is make a
few comments, and then if the submitter does not reply then I'll close the
ticket and let someone else submit this package.

The package in the original comment does build OK for me in rawhide.  I don't
see any of the errors or warnings listed in comment 3.  Not sure why; Java
isn't really my field.

The package really needs to be noarch; I see nothing arch-specific about the
package, rpmlint complains about it (no-binary) and the debuginfo package is
empty.  That would all be fixed with BuildArch: noarch.

There are various bits of the spec which are unnecessary in modern Fedora:
BuildRoot:, the first line of %install, and the entire %clean section.  You
should remove them unless you intend to target EPEL with the same spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list