[Bug 647076] Review Request: jackbeat - audio sequencer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647076

Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oget.fedora at gmail.com

--- Comment #12 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2010-11-03 01:05:18 EDT ---
A couple quick points from me too before we do a full review:

* You don't need BuildRequires (BR) to autoconf and zlib-devel

* You need to BR libxml2-devel and libsamplerate-devel
It's always to build your package in mock to test whether you are missing any
BRs.

- You mix up two macro conventions, which is not recommended. For example, if
you are using %{__make}, %{__rm} etc, you want to use %{__sed}. Conversely, if
you use sed, then you want to use make and rm. I prefer the latter convention
but that's just me.

! Please make the %description span 80 columns as much as possible. Currently
it is set to 70 columns max.

! At Fedora, we don't put Author information in %description

! It would be good to explain in the spec file as comments where additional
patches and sources come from and/or what they are for. The .desktop file can
probably be sent upstream. I guess you derived the .png file from
pkgdata/pixmaps/jackbeat_logo.png . Can you do a higher resolution one, so this
looks nicer in the desktop menu?

* It would be good if you make the .desktop file a little nicer. Here are a few
suggestions:
   - Add a "Comment:". Remember that Gnome uses "Comment" whereas KDE uses
"GenericName". No need to repeat the application name in the "Comment" or
"GenericName".
   - You need to add the category AudioVideo; I think this will be mandatory
soon.
   - If you add a X-Jack; category, the application will nicely coexist in our
Jack menu with other Jack applications. (did you install the multimedia-menus
package?)


Thanks for packaging this!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.