[Bug 635382] Review Request: perl-Tk-Text-SuperText - Improved text widget for perl/tk

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 3 18:18:47 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635382

--- Comment #2 from Lubomir Rintel <lkundrak at v3.sk> 2010-11-03 14:18:46 EDT ---
(In reply to comment #1)
> Source tar ball is original. Ok.
> License verified from README. Ok.
> FIX: BuildRequires is missing perl(Tk) and perl(Tk::Derived) (SuperText.pm).

Tk::Text apparently drags them in. Do you insist on pulling them in? You know,
fedora-qa script would complain that I have unnecessarily duplicate
dependencies if I added them =]

> FIX: Description miss space after full stop and has dangling `New Features:'
> string.

Uh, fixed.

> TODO: The test is never run as modern rpmbuild unset DISPLAY. Consider running
> tests against Xvfb.

Done.

SPEC: http://v3.sk/~lkundrak/SPECS/perl-Tk-Text-SuperText.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Tk-Text-SuperText-0.9.4-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list