[Bug 641341] Review Request: perl-File-Map - Memory mapping made simple and safe

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641341

--- Comment #3 from Lubomir Rintel <lkundrak at v3.sk> 2010-11-03 14:33:16 EDT ---
(In reply to comment #2)
> > Patch0:         perl-File-Map-0.31-pod.patch
> FIX: This is wrong as the bug is in Test::Pod that has been fixed in 1.41
> (http://cpansearch.perl.org/src/DWHEELER/Test-Pod-1.41/Changes). No Fedora is 
> affected, drop this patch or apply it conditionally on older RHEL distributions
> (if necessary).

Done.

> TODO: Submit the perl-File-Map-0.31-tie.patch patches to upstream.

Not done. This is a compat patch for older version of Perl, upstream may not be
necessarily interested in it. Dropped it from the package instead.

> FIX: BuildRequire perl(IO::Handle) (Build.PL and tests) as it can be dual-lived
> package in the future <http://search.cpan.org/~gbarr/IO/>.
> FIX: BuildRequire perl(Time::Hires) (Build.PL and tests) as it can be
> dual-lived package in the future <http://search.cpan.org/~jhi/Time-HiRes/>.

Done.

> FIX: Remove the private library from provides. You can do that by calling
> `%{?perl_default_filter}' macro right before %description section. See
> <https://fedoraproject.org/wiki/Perl_default_filter>.

Done.

> FIX: Remove executable bit from fastsearch.pl.

Done.

> > t/pod.t ........... skipped: Test::Pod 1.22 required for testing POD
> FIX: BuildRequire perl(Test::Pod) >= 1.22

Done.

SPEC: http://v3.sk/~lkundrak/SPECS/perl-File-Map.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-File-Map-0.31-3.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.