[Bug 467655] Review Request: yafaray - a raytracer for Blender.

Thu Nov 4 02:41:52 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467655

Ruediger Landmann <r.landmann at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |r.landmann at redhat.com
               Flag|                            |fedora-review?,
                   |                            |needinfo?(roma at lcg.ufrj.br)

--- Comment #81 from Ruediger Landmann <r.landmann at redhat.com> 2010-11-03 22:41:48 EDT ---
And I rebuilt and reinstalled today on F14 and it's still working fine, so I've
reviewed the package.

There are quite a few issues here. I'll start with a few basic ones:

* The project consistently calls the tool YafaRay, so I think this is an
instance where we should not change the capitalization

* The project website says that the license is LGPL2.1, with no "or later", so
you need to correct the License: to state the specific version

* You should not use the name YafaRay in the Summary:

* The upstream sources have moved to new URLs, so you need to update the
Source0: and Source1: lines

* In comment #78, kwizart said that he would obsolete Yafray; so I guess you
should now uncomment the Obsoletes: and Provides: lines

* Typo in Description: "capabilties"

* If you added "YafaRay can be used with official releases of Blender 3D" to
the Description: because of previous problems people reported with using this
package with the version of Blender shipped in Fedora, I think you can remove
this now -- it seems to work with the Blender we currently ship.

Other issues:
* normally, .so files belong in a -devel subpackage, but I'm not sure this is
the case here. I will investigate further.

* rpmlint gives "no-soname" warnings for:
    /usr/lib64/libyafaraycore.so
    /usr/lib64/libyafarayqt.so
    /usr/lib64/libyafarayplugin.so
  Take a look at the suggestion here:
http://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#no-soname

* rpmlint gives "private-shared-object-provides" warnings for:
    /usr/lib64/python2.7/site-packages/_yafqt.so _yafqt.so()
    /usr/lib64/python2.7/site-packages/_yafrayinterface.so
_yafrayinterface.so()
  Take a look at:
http://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#private-shared-object-provides

==FULL REVIEW==
 - = N/A
 / = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [!] Rpmlint output is clean:
        $ rpmlint SPECS/yafaray.spec 
        SPECS/yafaray.spec:32: W: macro-in-comment %{version}
        SPECS/yafaray.spec:33: W: macro-in-comment %{version}
        SPECS/yafaray.spec:33: W: macro-in-comment %{release}
        SPECS/yafaray.spec: W: invalid-url Source1:
http://www.yafaray.org/sites/default/files/download/builds/YafaRay-blender.0.1.1.zip
HTTP Error 404: Not Found
        SPECS/yafaray.spec: W: invalid-url Source0:
http://www.yafaray.org/sites/default/files/download/builds/YafaRay.0.1.1.zip
HTTP Error 404: Not Found
        0 packages and 1 specfiles checked; 0 errors, 5 warnings.
        $ rpmlint SRPMS/yafaray-0.1.1-1.fc14.src.rpm 
        yafaray.src: W: spelling-error Summary(en_US) raytracing -> ray
tracing, ray-tracing, tracing
        yafaray.src: W: name-repeated-in-summary C YafaRay
        yafaray.src: W: spelling-error %description -l en_US raytracing -> ray
tracing, ray-tracing, tracing
        yafaray.src: W: spelling-error %description -l en_US Raytracing -> Ray
tracing, Ray-tracing, Tracing
        yafaray.src: W: spelling-error %description -l en_US capabilties ->
capabilities, capability, capacities
        yafaray.src:32: W: macro-in-comment %{version}
        yafaray.src:33: W: macro-in-comment %{version}
        yafaray.src:33: W: macro-in-comment %{release}
        yafaray.src: W: invalid-url Source1:
http://www.yafaray.org/sites/default/files/download/builds/YafaRay-blender.0.1.1.zip
HTTP Error 404: Not Found
        yafaray.src: W: invalid-url Source0:
http://www.yafaray.org/sites/default/files/download/builds/YafaRay.0.1.1.zip
HTTP Error 404: Not Found
        1 packages and 0 specfiles checked; 0 errors, 10 warnings.
        $ rpmlint RPMS/x86_64/yafaray-0.1.1-1.fc14.x86_64.rpm 
        yafaray.x86_64: W: spelling-error Summary(en_US) raytracing -> ray
tracing, ray-tracing, tracing
        yafaray.x86_64: W: name-repeated-in-summary C YafaRay
        yafaray.x86_64: W: spelling-error %description -l en_US raytracing ->
ray tracing, ray-tracing, tracing
        yafaray.x86_64: W: spelling-error %description -l en_US Raytracing ->
Ray tracing, Ray-tracing, Tracing
        yafaray.x86_64: W: spelling-error %description -l en_US capabilties ->
capabilities, capability, capacities
        yafaray.x86_64: W: no-soname /usr/lib64/libyafaraycore.so
        yafaray.x86_64: W: no-manual-page-for-binary yafaray-xml
        1 packages and 0 specfiles checked; 0 errors, 7 warnings.
        $ rpmlint RPMS/x86_64/yafaray-blender-0.1.1-1.fc14.x86_64.rpm 
        yafaray-blender.x86_64: W: spelling-error %description -l en_US Yaf ->
Yafo, Oaf, Yap
        yafaray-blender.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/_yafqt.so _yafqt.so()(64bit)
        yafaray-blender.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/_yafrayinterface.so
_yafrayinterface.so()(64bit)
        yafaray-blender.x86_64: W: no-soname /usr/lib64/libyafarayqt.so
        yafaray-blender.x86_64: W: no-soname /usr/lib64/libyafarayplugin.so
        yafaray-blender.x86_64: W: no-documentation
        1 packages and 0 specfiles checked; 0 errors, 6 warnings.
        $ rpmlint RPMS/x86_64/yafaray-debuginfo-0.1.1-1.fc14.x86_64.rpm 
        1 packages and 0 specfiles checked; 0 errors, 0 warnings.

 [!] Package is named according to the Package Naming Guidelines.
        "Keep in mind to respect the wishes of the upstream maintainers. If
they refer to their application as "ORBit", you should use "ORBit" as the
package name, and not "orbit". However, if they do not express any preference
of case, you should default to lowercase naming." --
http://fedoraproject.org/wiki/PackageNamingGuidelines
        Upstream consistently capitalizes the name as "YafaRay". Unless you've
contacted them to determine that they don't care, Fedora should follow their
guidance.
 [/] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [/] Package meets the Packaging Guidelines including the Language specific
items
 [/] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [!] License field in the package spec file matches the actual license.
        From the project website: "YafaRay is released under the LGPL 2.1
license."
        specfile says "LGPLv2+"
 [/] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [/] Spec file is legible and written in American English.
 [!] Sources used to build the package matches the upstream source, as provided
in the spec URL.
        Sources are no longer available at URL in spec; however, they match
what is available on the project website:
        $ md5sum SOURCES/YafaRay.0.1.1.zip 
        d1722dec25299f6f3fcc1d7c661a4e90  SOURCES/YafaRay.0.1.1.zip
        $ md5sum ~/Download/YafaRay.0.1.1.zip 
        d1722dec25299f6f3fcc1d7c661a4e90 
/home/rlandmann/Download/YafaRay.0.1.1.zip
        $ md5sum SOURCES/YafaRay-blender.0.1.1.zip 
        d7e7f86b9e90e7f960707ebaea1843ab  SOURCES/YafaRay-blender.0.1.1.zip
        $ md5sum ~/Download/YafaRay-blender.0.1.1.zip 
        d7e7f86b9e90e7f960707ebaea1843ab 
/home/rlandmann/Download/YafaRay-blender.0.1.1.zip
 [] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=2575603
 [/] Package is not known to require ExcludeArch
 [/] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly (with the %find_lang macro)
 [-] ldconfig called in %post and %postun if required.
 [/] Package does not bundle copies of system libraries
 [/] Package is not relocatable.
 [/] Package must own all directories that it creates.
 [/] Package does not contain duplicates in %files.
 [-] Permissions on files are set properly
 [/] %files section includes a %defattr(...) line
 [/] Package consistently uses macros.
 [-] Large documentation files are in a -doc subpackage, if required.
 [/] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [!] Development .so files in -devel subpackage, if present.
 [!] -devel packages require base package with full versioning.
 [/] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [/] Package does not own files or directories owned by other packages.
 [/] Filenames are valid UTF-8

=== SUGGESTED ITEMS ===

 [/] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [/] Reviewer should test that the package builds in mock.
     Tested through koji
 [/] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: f14
 [/] Package functions as described.
 [/] Scriptlets must be sane, if used.
 [/] Subpackages other than -devel require the base package as a fully
versioned
dependency
 [-] The placement of pkgconfig(.pc) files is correct (normally in -devel)
 [-] File based requires are sane.
 [!] Package contains man pages for binaries and scripts.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.