[Bug 637521] Review Request: php-phpunit-DbUnit - DbUnit port for PHP/PHPUnit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637521

Christof Damian <christof at damian.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christof at damian.net
         AssignedTo|nobody at fedoraproject.org    |christof at damian.net
               Flag|                            |fedora-review+

--- Comment #1 from Christof Damian <christof at damian.net> 2010-11-04 04:54:22 EDT ---
MUST:

OK: rpmlint must be run on every package. 

1 packages and 1 specfiles checked; 0 errors, 0 warnings.

OK: The package must be named according to the Package Naming Guidelines 
OK: The spec file name must match the base package %{name}
OK: The package must meet the Packaging Guidelines 
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines 
OK: The License field in the package spec file must match the actual license. 
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

07b6b9d544c08b54aea840ed05a99ed0  DbUnit-1.0.0.tgz

OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
builds in mock f14

OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present. 
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT). 
OK: All filenames in rpm packages must be valid UTF-8.

SHOULD:

OK: The reviewer should test that the package builds in mock. 

builds in f14 (f13 + epel-6 are missing php-pear(PEAR) >= 1.9.1)

COMMENTS:

- I would prefer https://github.com/sebastianbergmann/dbunit as the 
  URL instead of the pear channel URL.

*** APPROVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.