[Bug 637939] Review Request: rubygem-gdk_pixbuf2 - Ruby binding of GdkPixbuf-2.x

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637939

Michal Fojtik <mfojtik at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(mfojtik at redhat.co |fedora-cvs+
                   |m)                          |

--- Comment #6 from Michal Fojtik <mfojtik at redhat.com> 2010-11-04 06:10:09 EDT ---
I'm really sorry for the delay, as usually, this package looks perfectly sane
for me:

* Packages that contain Ruby Gems must be called rubygem-%{gemname} where
gemname is the name from the Gem's specification.

[OK]

* The Source of the package must be the full URL to the released Gem archive;
th version of the package must be the Gem's version

[!] Please correct URL to:
http://rubygems.org/downloads/%{gemname}-%{version}.gem

The package must have a Requires and a BuildRequires on rubygems

[OK]

For every dependency on a Gem named gemdep, the package must contain a Requires
on rubygem(%{gemdep}) with the same version constraints as the Gem

[OK]

The %prep and %build sections of the specfile should be empty.

[OK] -> They are not empty, but it's OK for binary extensions

The Gem must be installed into %{gemdir} defined as
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)

[OK]

Architecture-specific content must not be installed into %{gemdir}

[OK]

If the Gem contains binary content (e.g., for a database driver), it must be
marked as architecture specific, and all architecture specific content must be
moved from the %{gemdir} to the [#ruby_sitearch %{ruby_sitearch} directory]
during %install

[OK]

Other things looks good as well. REVIEW+

(Please correct that URL before importing this gem into git)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.