[Bug 531363] Review request: WiKIDToken - Token for the WiKID Strong Authentication System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531363

--- Comment #4 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-04 12:54:13 EDT ---
Java isn't my strong suit; I'll make some comments and hopefully the Java SIG
folks can help out.

In %prep, you need to delete any jar and class files present in the zip.  It
looks like there's a pile of bundled stuff in there, and we need to make sure
that none of it gets into the final package.  Unfortunately I did that and the
package fails to build, so it looks like you're relying on that bundled stuff.

Bundling libraries in that manner is not permissible in Fedora.  See
http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries
and and http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries for more
information.

This is a strong blocker, but there are a few other things I see on a first
glance.

Please remove the suse stuff from the spec.

Don't reference $RPM_BUILD_DIR at all.

Don't redefine %_prefix.

You probably want %_datadir instead of defining %_sharedir to what %_datadir 
normally contains.

Be careful of using macros in comments.  '#' isn't a comment character in a
spec file, and macros are still expanded.  This means that multiline macros
will cause problems.

Do you really find it simpler to use "%__chmod" instead of just "chmod"?  If
so, you need to be consistent, so use %__mkdir, %__mkdir_p and such as well. 
Or just drop the needless complexity and call the commands directly.

Don't mix usage of %buildroot and $RPM_BUILD_ROOT.  Pick one style and use it
consistently.

Fedora does not need BuildRoot:, the first line of %install or the %clean
section.  (EPEL 4 and 5 still do, though, so it's not mandatory that you remove
them.)

%fedora_version, %rhel_version and %centos_version are not defined anywhere in
your spec, and they aren't defined in the buildsystem.  You should remove them.
 If you want to conditionalize things based on RHEL or Fedora versions, see
http://fedoraproject.org/wiki/Packaging:DistTag.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.