[Bug 649939] Review Request: loook - search tool for OpenOffice.org documents

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=649939

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tomspur at fedoraproject.org
         AssignedTo|nobody at fedoraproject.org    |tomspur at fedoraproject.org

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-11-04 21:05:49 EDT ---
Nice a python3 package :-)

The loook-0.6.7-python3-env.patch is wrong, you force to use python3.1, but
what's up, when python3.2 arrives?
Better just use python3 there and that's it...

- %files: sitelib and not sitearch

- compressing of the manpage happens automatically, so please just install
%{name}.1 and don't use gzip

- you do:
  %py_byte_compile %{__python3} %{buildroot}%{_datadir}/%{name}/

  But there are no files there... Can this be deleted?

- %global         debug_package %{nil}:
  that's not needed for noarch packages, please delete that.

- license is wrong: it's GPLv2+ and not just GPLv2

The rest looks fine to me...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.