[Bug 649777] Review Request: jorbis - Pure Java Ogg Vorbis Decoder

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=649777

Lukáš Zapletal <lzap at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lzap at redhat.com

--- Comment #1 from Lukáš Zapletal <lzap at redhat.com> 2010-11-05 08:52:11 EDT ---
Unofficial formal review:

# MUST: rpmlint must be run on every package. The output should be posted in
the review.[1]
OK

# MUST: The package must be named according to the Package Naming Guidelines .
OK

# MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
OK

# MUST: The package must meet the Packaging Guidelines .
OK

# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
OK

# MUST: The License field in the package spec file must match the actual
license. [3]
OK

# MUST: The spec file must be written in American English. [5]
OK

# MUST: The spec file for the package MUST be legible. [6]
OK

# MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK

# MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
OK

# MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK

# MUST: Packages must NOT bundle copies of system libraries.[11]
OK

# MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [13]
OK

# MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
OK

# MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. [15]
OK

# MUST: Each package must consistently use macros. [16]
OK

# MUST: The package must contain code, or permissable content. [17]
OK

# MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18]
OK

# MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18]
OK

# MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} [21]
OK

# MUST: Packages must not own files or directories already owned by other
packages.
OK

# MUST: All filenames in rpm packages must be valid UTF-8. [24]
OK

TOTAL: ALL OK

Java Guidelines: ALL OK

rpmlint jorbis-0.0.17-1.fc14.src.rpm 
jorbis.src:36: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 36)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.