[Bug 648267] Review Request: perl-CGI-Application-Plugin-LinkIntegrity - Make tamper-resistant links in CGI::Application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648267

--- Comment #1 from Petr Pisar <ppisar at redhat.com> 2010-11-05 13:01:37 EDT ---
Source original. Ok.
License verified from lib/CGI/Application/Plugin/LinkIntegrity.pm and README.
Ok.

FIX: Add perl(Digest::MD5) BuildRequires as the module can dual-live in the
future (http://search.cpan.org/~gaas/Digest-MD5/).

perl(CGI) and perl(CGI::Application) minimal versions are greater in all
supported distributions. Missing versions are Ok.

Summary and Description verified from
lib/CGI/Application/Plugin/LinkIntegrity.pm. Ok.

All tests pass. Ok.

$ rpmlint perl-CGI-Application-Plugin-LinkIntegrity.spec
../SRPMS/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.src.rpm
../RPMS/noarch/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

rpmlint Ok.

$ rpm -pq -vl
../RPMS/noarch/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.noarch.rpm 
drwxr-xr-x    2 root    root                        0 lis  5 17:43
/usr/share/doc/perl-CGI-Application-Plugin-LinkIntegrity-0.06
-rw-r--r--    1 root    root                     2808 kvě 18  2006
/usr/share/doc/perl-CGI-Application-Plugin-LinkIntegrity-0.06/Changes
-rw-r--r--    1 root    root                    13592 kvě 18  2006
/usr/share/doc/perl-CGI-Application-Plugin-LinkIntegrity-0.06/README
-rw-r--r--    1 root    root                     6162 lis  5 17:43
/usr/share/man/man3/CGI::Application::Plugin::LinkIntegrity.3pm.gz
drwxr-xr-x    2 root    root                        0 lis  5 17:43
/usr/share/perl5/CGI
drwxr-xr-x    2 root    root                        0 lis  5 17:43
/usr/share/perl5/CGI/Application
drwxr-xr-x    2 root    root                        0 lis  5 17:43
/usr/share/perl5/CGI/Application/Plugin
-rw-r--r--    1 root    root                    19092 lis  5 17:43
/usr/share/perl5/CGI/Application/Plugin/LinkIntegrity.pm

File layout and permissions Ok.

$ rpm -pq --requires
../RPMS/noarch/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.noarch.rpm
| sort | uniq -c
      1 perl(Carp)  
      1 perl(CGI::Application)  
      1 perl(Digest::HMAC)  
      1 perl(Exporter)  
      1 perl(File::Spec)  
      1 perl(:MODULE_COMPAT_5.10.1)  
      1 perl(strict)  
      1 perl(URI)  
      1 perl(URI::QueryParam)  
      1 perl(vars)  
      1 perl(warnings)  
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rpmlib(VersionedDependencies) <= 3.0.3-1
Binary requires Ok.

$ rpm -pq --provides
../RPMS/noarch/perl-CGI-Application-Plugin-LinkIntegrity-0.06-1.fc13.noarch.rpm
| sort | uniq -c
      1 perl(CGI::Application::Plugin::LinkIntegrity) = 0.06
      1 perl-CGI-Application-Plugin-LinkIntegrity = 0.06-1.fc13
Binary provides Ok.

Otherwise, package is in lines with Fedora and Perl packaging guidelines. Ok.

Package builds in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2579930). Ok.

> t/pod-coverage.t .................. skipped: Test::Pod::Coverage 1.04 required for testing POD coverage
FIX: Add perl(Test::Pod::Coverage ) >= 1.04 to BuildRequires.


Please correct all `FIX' prefixed issues and submit new spec file.
Resolution: Package NOT APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.