[Bug 502690] Review Request: mingw32-dirac - MinGW Windows dirac compression library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502690

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+

--- Comment #3 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-05 13:54:43 EDT ---
I'm trying to take care of the oldest of the review tickets; I had to learn
about mingw32 before I could look at this.

Outside of the spec having several bits which are unnecessary with modern
Fedora (BuildRoot:, cleaning of buildroot in %install, the entire %clean
section) which you can remove if you like, this package looks fine.

* source files match upstream.  sha256sum:
  816b16f18d235ff8ccd40d95fc5b4fad61ae47583e86607932929d70bf1f00fd
   dirac-1.0.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* version packaged is the same as the native Fedora version.
* package is noarch.
* BuildRequires are proper.
* compiler flags are appropriate.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* special mingw32 dependency generators are used.
* final provides and requires are sane:
   mingw32(libdirac_decoder-0.dll)  
   mingw32(libdirac_encoder-0.dll)  
   mingw32-dirac = 1.0.2-2.fc15
  =
   mingw32-filesystem >= 62
   mingw32-runtime  
   mingw32(kernel32.dll)  
   mingw32(libdirac_decoder-0.dll)  
   mingw32(libdirac_encoder-0.dll)  
   mingw32(libgcc_s_sjlj-1.dll)  
   mingw32(libstdc++-6.dll)  
   mingw32(msvcrt.dll)  

*  owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no static libraries.
* .dll and .def files in _mingw32_bindir
* .dll.a and .la files in _mingw32_libdir
* dll files are listed explicitly in %files.
* libraries and executables are stripped properly.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.