[Bug 648465] Review Request: php-pear-Console-CommandLine - A full featured command line options and arguments parser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648465

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review?

--- Comment #1 from Remi Collet <fedora at famillecollet.com> 2010-11-06 04:02:10 EDT ---
Notes before review

1/ Don't use %channel for a package from default pear channel
Provides: php-pear(%{pear_name}) = %{version}

2/ License is not BSD but MIT

3/ Reduce path of 
/usr/share/doc/php-pear-Console-CommandLine-1.1.3/Console_CommandLine/docs/examples
To 
/usr/share/doc/php-pear-Console-CommandLine-1.1.3/examples

4/ add a %check section to run test suite

%check
cd %{pear_name}-%{version}
PHPRC=./php.ini %{__pear} run-tests tests | tee tests.log
# run-tests doesn't set return code, so grep it
grep "FAILED TESTS" tests.log && exit 1

OR 

%check
cd %{pear_name}-%{version}
%{_bindir}/phpunit tests

I prefer the "phpunit" version, which set the return code and display failing
tests output. But which need additional BR php-pear(pear.phpunit.de/PHPUnit)

Build in mock (with %check) is ok.

5/ must own 
%{pear_phpdir}/Console

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.