[Bug 648466] Review Request: php-phpunit-PHP-CodeBrowser - PHP_CodeBrowser for integration in Hudson and CruiseControl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648466

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review?

--- Comment #1 from Remi Collet <fedora at famillecollet.com> 2010-11-06 04:40:59 EDT ---
First notes

1/ See comment about requires in review #648465
So Requires should be

Requires:       php-pear(Console_CommandLine) >= 1.1.3
Requires:       php-pear(pear.phpunit.de/File_Iterator) >= 1.2.1
Requires:       php-pear(Log) >= 1.12.1

2/ doc should be moved in %doc :
/usr/share/pear/doc/PHP_CodeBrowser/CHANGELOG.markdown
/usr/share/pear/doc/PHP_CodeBrowser/LICENSE
/usr/share/pear/doc/PHP_CodeBrowser/README.markdown

Well, the %doc %{pear_docdir}/%{pear_name} should be ok, but all other package
use /usr/share/doc/php-phpunit-PHP-CodeBrowser-0.9.1... (except for php-pear,
and there is open bug about this...)

I'm really annoyed with this doc... as the result from "pear list-files" is
false when moved to another dir.

Could a link from %{pear_docdir}/%{pear_name} to
/usr/share/doc/php-phpunit-PHP-CodeBrowser-0.9.1 be acceptable by Guidelines ?
(we should raise a FPC discussion about this)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.