[Bug 646139] Review Request: KXStitch - tool that creates cross stitch patterns

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646139

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #2 from Martin Gieseking <martin.gieseking at uos.de> 2010-11-06 12:01:38 EDT ---
Hi Golo,

here are some initial comments on your package:

- Drop the leading article "A" from the Summary to keep it concise.

- Adapt Source0 according to 
  http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

- You can drop BR: qt3-devel, ImageMagick-devel, libjpeg-devel, kernel-headers. 
  They are not required or automatically added as dependencies.

- Don't compress the manpage manually. rpmbuild does it for you. Thus, remove 
  the gzip and rm lines in %install, and replace 
  %doc %{_mandir}/man1/kxstitch.1.gz with 
  %{_mandir}/man1/kxstitch.1* (no %doc prefix here).

- If you put anything into %{_datadir}/icons, you must update the GTK icon 
  cache. 
  See http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

- Drop INSTALL from %files as it's not of much use in a binary package.

- Please add empty lines between the %changelog entries to increase legibility.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.