[Bug 650643] Review Request: cegui06 - CEGUI library 0.6 for apps which need this specific version

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 8 10:09:16 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=650643

--- Comment #4 from Hans de Goede <hdegoede at redhat.com> 2010-11-08 05:09:15 EST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Hello I'm not a sponsor, but I have a few suggestions reviewing you package.
> > > 
> > > Change the comments above the Source0 field on how to generate the tarball used
> > > in the srpm
> > 
> > That means I would need to update the comment with each new upstream release,
> > thanks but no thanks.
> > 
> 
> This is a MUST
> https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code
> 
> i.e. If you modify the upstream tarball, you must provide the
>      way in detail how you generated the new tarball.

I'm doing that! I was referring to how replacing %{version} in the generate
instructions with the actual version would require me to update the generate
instructions each release. If the generation procedure changes the instructions
need to be updated of course.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list