[Bug 649874] Review Request: perl-Object-Pluggable - Base class for creating plugin-enabled objects

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=649874

Petr Sabata <psabata at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Petr Sabata <psabata at redhat.com> 2010-11-08 07:35:40 EST ---
(In reply to comment #2)
> (In reply to comment #1)
> > === Issues ===
> > 1. The provided specfiles differs from the one in SRPM
> Fixed.
[confirmed]

> 
> > 2. Package should BuildRequire perl(Pod::Parser) >= 1.36
> Pod tests are not mandatory (I guess), but I included them (more BR were
> needed).
[confirmed]

> 
> > 3. Buildroot not specified
> BuildRoot is not needed since F-12
It's not required but makes the package more portable. It would be nice to have
it but let's not consider it a review blocker.

> 
> > 4. rpmlint compains about spelling in %description, s/plugin/plug-in/ for en_US
> Fixed.
[confirmed]

> 
> > 5. t/99_pod.t isn't run because of Issue No. 2
> Fixed.
[confirmed]

> 
> SPEC: http://mmaslano.fedorapeople.org/review/perl-Object-Pluggable.spec
> SRPM:
> http://mmaslano.fedorapeople.org/review/perl-Object-Pluggable-1.29-1.fc14.src.rpm

The rest seems okay, package still builds, all tests pass...

================
*** APPROVED ***
================

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.