[Bug 527462] Review Request: python-gmpy - Python interface to GMP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527462

Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
             Blocks|201449(FE-DEADREVIEW)       |
         Resolution|NOTABUG                     |
         AssignedTo|nobody at fedoraproject.org    |jussi.lehtola at iki.fi
               Flag|                            |fedora-review?
           Keywords|                            |Reopened

--- Comment #11 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-11-08 09:57:33 EST ---
A few notes:

- add a description.

- You're mixing styles: %{buildroot} vs. $RPM_BUILD_ROOT. Choose one and stick
with it.

- Please add " -O1 --skip-build" to the install command as in the python
specfile template.

- The %files section needs improvement. The statement
 %{python_sitearch}/
ends up owning the system python directory, which is not wanted. Probably it
should be something like
 %{python_sitearch}/gmpy/
 %{python_sitearch}/gmpy-%{version}-py*.egg-info/
to behave nicely.

- This is an arch dependent package, so the build command should include a
CFLAGS statement, as in the python specfile template
 CFLAGS="$RPM_OPT_FLAGS" python setup.py build
If you go with macro style, change $RPM_OPT_FLAGS to %{optflags}.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.