[Bug 531544] Review Request: python-trml2pdf - Tiny RML2PDF is a tool to easily create PDF documents without programming

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=531544

--- Comment #12 from Cristian Ciupitu <cristian.ciupitu at yahoo.com> 2010-11-08 11:57:18 EST ---
(In reply to comment #9)
> Please up the Release number whenever you make a new spec file.

I thought that this doesn't make too much sense when the SPEC is still work in
progress.


> Needswork:
> * License is LGPLv2+.  Please update the spec file to reflect that.

Fixed.

> Note:
> * Removing the python_sitelib definition is fine as long as you are not
>   planning on building on older releases.  If you do want to build this on F13
>   or less or EL-4 or EL-5 you will need to add it back in.

I'm aiming for Fedora 14. EL4 is out of the question because as far as I know
it offers Python 2.3 which is too old. EL5 might be an option, given the fact
that Satchmo is supposed to work on Python 2.4, but there were some hiccups[1]
which required Python 2.5. Also I don't use EL5, so I don't know if I could
provide support for it.

> * Upstream seems dead as you note but there's several projects that have
> copies:
>   - satchmo (where you got the tarball from)
> http://www.satchmoproject.com/snapshots/
>   - kraft: http://sourceforge.net/projects/kraft/files/
>   - template2pdf: http://code.google.com/p/template2pdf/
> 
>   It would be very nice if you could contact these groups and get them to
>   revive the project in some shape or form.  For instance, everyone could
>   contirbute to the template2pdf project and make that module the new upstream
> 
>   Currently the tarballs for these projects do not match but the differences
>   are minor and not in the code.  satchmo has a setup.py file, kraft is saved
>   as tar.bz2, template2pdf has bundled the module in their code.

I'm packing trml2pdf as a dependency for Satchmo, so this is my upstream at
least for now.

> * Realize that currently, as there is no upstream for this package, you are
>   putting yourself on the hook for fixing anything wrong in the code, bugs,
>   security issues, etc.  This can be alleviated if you get those other projects
>   to help out in creating a new canonical upstream.

I'm counting on the Satchmo developers for fixes, but given my Python skills I
could fix some minor bugs myself. Anyway, creating a new canonical upstream is
an interesting idea. By the way, Satchmo tried to replace trml2pdf with
something else, but without any luck[2].

> rpmlint:
> 
> python-trml2pdf.src: W: no-cleaning-of-buildroot %clean
> python-trml2pdf.src: W: no-%clean-section
> 
> Both of these are something that's needed in EPEL builds but not F-14.  If
> you're not planning to build on EPEL-5 then you don't need to worry about this.

See above.

> python-trml2pdf.noarch: W: no-manual-page-for-binary trml2pdf
> 
> This is not a requirement but if you want to write a man page for the script,
> it would be helpful for people looking to run it.  It doesn't look like Debian
> has one so we'd have to write one rather than copy it.  This is not a blocker.

I have not used the script myself nor have I ever written a man page, but I
could give it try. Regarding Debian, I think that it does have a man page[3]. 

> Summary:
> 
> So fixing the licensing issue is the only blocker to the package.  Do take the
> things in the Note section under consideration.

I'll update the SPEC and the SRC.rpm in a couple of hours.

> I also don't see any reviews from you.  There's quite a few python-* reviews
> listed here: 
> http://fedoraproject.org/PackageReviewStatus/NEW.html
> 
> I know that the maintainer of the python-zope-* packages is quite active if you
> want a relatively quick turnaround time.  If you'll just choose one review and
> let me know what you're doing, I'll check your review and then sponsor you so
> you can officially complete it.

I'll try to be more active. I've already looked at 2 requests:
- https://bugzilla.redhat.com/show_bug.cgi?id=547621#c1
- https://bugzilla.redhat.com/show_bug.cgi?id=578024#c33


[1] http://bitbucket.org/chris1610/satchmo/changeset/98c41ad27249
[2] http://bitbucket.org/chris1610/satchmo/wiki/PdfCreation
[3]
http://svn.debian.org/viewsvn/python-modules/packages/python-trml2pdf/trunk/debian/trml2pdf.1?view=markup

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.