[Bug 648549] Review Request: spice-vdagent - Agent for Spice guests

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648549

--- Comment #4 from Hans de Goede <hdegoede at redhat.com> 2010-11-08 16:47:04 EST ---
Hi,

Thanks for the review!

>      spice-vdagent.src: W: spelling-error %description -l en_US uinput ->
> input, u input, sinciput
>      spice-vdagent.x86_64: W: spelling-error %description -l en_US uinput ->
> input, u input, sinciput

<sigh>, rpmlint is stupid wrt spelling errors, uinput is the correct term these
can safely be ignored.

>      spice-vdagent.x86_64: W: non-conffile-in-etc
> /etc/xdg/autostart/spice-vdagent.desktop

And another favorite useless rpmlint warnings some files under /etc
are not meant for user modification and thus not marked %config,
files under /etc/xdg is one of the groups of files which should not
be %config even though being under /etc.

>      spice-vdagent.x86_64: W: no-manual-page-for-binary spice-vdagentd
>      spice-vdagent.x86_64: W: no-manual-page-for-binary spice-vdagent

Not really an issue as they are not meant to be directly started from the
cmdline, let alone started with options on the cmdline. They are automatically
started as service, resp. by .desktop files -> no need for manpage.

>      spice-vdagent.x86_64: W: service-default-enabled
> /etc/rc.d/init.d/spice-vdagentd

Yes, and intentionally so. The initscript is a no-op (exits immediately) when
not running under spice.

>      spice-vdagent.x86_64: E: malformed-line-in-lsb-comment-block # daemon
> enhances the spice guest user experience with client
>      spice-vdagent.x86_64: E: malformed-line-in-lsb-comment-block # mouse mode,
> guest <-> client copy and paste support and more.

Oh rpmlint found a real issue. I'll upload a fixed package.

>      spice-vdagent.x86_64: W: incoherent-subsys /etc/rc.d/init.d/spice-vdagentd

<sigh> and another useless rpmlint check

> === Issues ===
> 1. Most important for me in this review is the rpmlint output, as it has some
> errors and warnings. The first 4 warnings are acceptable for me. However, as
> you know this is my first review, and I've never seen these errors/warnings
> before. If you didn't see them before, please try to correct them. If they are
> acceptable, please explain why. 

See above, please don't take it personal if I sound a bit grumpy above.
Although rpmlint is a very useful tool (as shown by the one real issue did
find) sometimes it makes me <sigh> a lot because some of its checks are useless
(like the terrible newly added spelling checking failure).

But still it did find one real issue I'll upload a new version with this fixed
soon.

> 2. This is a should, but I was not able to successfully compile the package in
> mock because of the updates-testing requirement for one of the BRs.

The needed spice-protocol package is in stable updates now :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.