[Bug 648267] Review Request: perl-CGI-Application-Plugin-LinkIntegrity - Make tamper-resistant links in CGI::Application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648267

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Petr Pisar <ppisar at redhat.com> 2010-11-09 03:45:41 EST ---
Spec file changes:

--- perl-CGI-Application-Plugin-LinkIntegrity.spec 2010-10-31
19:04:21.000000000 +0100
+++ perl-CGI-Application-Plugin-LinkIntegrity.spec.1 2010-11-08
21:21:51.000000000 +0100
@@ -1,6 +1,6 @@
 Name:           perl-CGI-Application-Plugin-LinkIntegrity
 Version:        0.06
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Make tamper-resistant links in CGI::Application
 License:        GPL+ or Artistic
 Group:          Development/Libraries
@@ -11,9 +11,11 @@
 BuildRequires:  perl(CGI)
 BuildRequires:  perl(CGI::Application)
 BuildRequires:  perl(Digest::HMAC)
+BuildRequires:  perl(Digest::MD5)
 BuildRequires:  perl(Module::Build)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(Test::Pod)
+BuildRequires:  perl(Test::Pod::Coverage) >= 1.04
 BuildRequires:  perl(URI)
 BuildRequires:  perl(URI::Escape)
 BuildRequires:  perl(URI::QueryParam)
@@ -53,5 +55,8 @@
 %{_mandir}/man3/*

 %changelog
+* Mon Nov 08 2010 Emmanuel Seyman <emmanuel.seyman at club-internet.fr> - 0.06-2
+- Fix spec file per review
+
 * Sun Oct 31 2010 Emmanuel Seyman <emmanuel.seyman at club-internet.fr> 0.06-1
 - Specfile autogenerated by cpanspec 1.78.


> > FIX: Add perl(Digest::MD5) BuildRequires as the module can dual-live in the
> > future (http://search.cpan.org/~gaas/Digest-MD5/).
> +BuildRequires:  perl(Digest::MD5)
Ok.

> > > t/pod-coverage.t .................. skipped: Test::Pod::Coverage 1.04 required for testing POD coverage
> > FIX: Add perl(Test::Pod::Coverage ) >= 1.04 to BuildRequires.
> +BuildRequires:  perl(Test::Pod::Coverage) >= 1.04
Ok.

Package builds in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2589305). Ok.


Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.