[Bug 648266] Review Request: perl-CGI-Application-Plugin-JSON - Easy manipulation of JSON headers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648266

Petr Pisar <ppisar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Petr Pisar <ppisar at redhat.com> 2010-11-09 04:37:51 EST ---
Spec file changes:

--- perl-CGI-Application-Plugin-JSON.spec 2010-10-31 19:44:05.000000000 +0100
+++ perl-CGI-Application-Plugin-JSON.spec.1 2010-11-08 21:22:22.000000000 +0100
@@ -1,6 +1,6 @@
 Name:           perl-CGI-Application-Plugin-JSON
 Version:        1.02
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Easy manipulation of JSON headers
 License:        GPL+ or Artistic
 Group:          Development/Libraries
@@ -8,12 +8,13 @@
 Source0:       
http://www.cpan.org/authors/id/W/WO/WONKO/CGI-Application-Plugin-JSON-%{version}.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:      noarch
-BuildRequires:  perl(CGI::Application)
-BuildRequires:  perl(JSON)
-BuildRequires:  perl(JSON::Any)
+BuildRequires:  perl(CGI::Application) >= 4
+BuildRequires:  perl(JSON) >= 2.02
+BuildRequires:  perl(JSON::Any) >= 1.14
 BuildRequires:  perl(Module::Build)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(Test::Pod)
+BuildRequires:  perl(Test::Pod::Coverage)
 Requires:       perl(CGI::Application)
 Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

@@ -46,10 +47,13 @@

 %files
 %defattr(-,root,root,-)
-%doc Changes README TODO
+%doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*

 %changelog
+* Mon Nov 08 2010 Emmanuel Seyman <emmanuel.seyman at club-internet.fr> - 1.02-2
+- Fix spec file per review
+
 * Mon Oct 04 2010 Emmanuel Seyman <emmanuel.seyman at club-internet.fr> 1.02-1
 - Specfile autogenerated by cpanspec 1.78.


> > > BuildRequires:  perl(CGI::Application)
> > FIX: Add `>= 4' version constrain to the BuildRequires (META.yml)
> +BuildRequires:  perl(CGI::Application) >= 4
Ok.

> > > BuildRequires:  perl(JSON)
> > FIX: Add `>= 2.02' version constrain to the BuildRequires (META.yml)
> +BuildRequires:  perl(JSON) >= 2.02
Ok.

> > > BuildRequires:  perl(JSON::Any)
> > FIX: Add `>= 1.14' version constrain to the BuildRequires (META.yml)
> +BuildRequires:  perl(JSON::Any) >= 1.14
Ok.

> > FIX: Do not pack empty TODO file.
> -%doc Changes README TODO
> +%doc Changes README

$ rpm -pq -lv
../RPMS/noarch/perl-CGI-Application-Plugin-JSON-1.02-2.fc13.noarch.rpm 
drwxr-xr-x    2 root    root                        0 lis  9 10:28
/usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02
-rw-r--r--    1 root    root                      789 dub  8  2009
/usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/Changes
-rw-r--r--    1 root    root                     4459 dub  8  2009
/usr/share/doc/perl-CGI-Application-Plugin-JSON-1.02/README
-rw-r--r--    1 root    root                     3414 lis  9 10:28
/usr/share/man/man3/CGI::Application::Plugin::JSON.3pm.gz
drwxr-xr-x    2 root    root                        0 lis  9 10:28
/usr/share/perl5/CGI
drwxr-xr-x    2 root    root                        0 lis  9 10:28
/usr/share/perl5/CGI/Application
drwxr-xr-x    2 root    root                        0 lis  9 10:28
/usr/share/perl5/CGI/Application/Plugin
-rw-r--r--    1 root    root                     7192 lis  9 10:28
/usr/share/perl5/CGI/Application/Plugin/JSON.pm

Ok.

> FIX: Add version to Requires: perl(CGI::Application) and perl(JSON::Any) as
> stated in META.yml.
All supported Fedoras fulfill minimal versions. Ok.

> > FIX: BuildRequire perl(Test::Pod::Coverage) >= 1.04
> +BuildRequires:  perl(Test::Pod::Coverage)
All supported Fedoras fulfill minimal versions. Ok.

All tests pass. Ok.

Package builds in F15
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2589434). Ok.


Resolution: Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.