[Bug 651693] Review Request: libxkbcommon - X.Org X11 XKB parsing library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651693

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-11-10 04:58:38 EST ---
Package failed to build in mock, looks missing BR:byacc and libX11-devel

Following are not blockers but good to implement as packaging guidelines
suggests their usage.

1) Guidelines says there is no need of buildroot tag in spec,
https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag
and also for EPEL, See
https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag

2) See,https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
We don't need Requires for -devel as they are automatically extracted by rpm.

3) Guidelines suggests to keep timestamps of upstream installed files. So
please use 
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

4) Guidelines suggests package built above F-13 do not need %clean
See https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean


5) --disable-specs is a unrecognized option to %configure

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.