[Bug 638590] Review Request: freemind - a mind-mapping software written in Java

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638590

--- Comment #6 from Stanislav Ochotnicky <sochotni at redhat.com> 2010-11-10 08:22:30 EST ---

Few notes before I start official review:
 * Group should probably be Application/Productivity
 * Package doesn't build in rawhide now (jakarta-* packages renamed to
apache-*)
 * Instead of patching paths in build.xml files, use build-jar-repository
 * FYI: you can use "attr(755,root,root) binfile" instead of chmodding script
during install
 * From spec file it seems you don't own %{_javadir}/%{name} (which you
should).
   So instead of all those separate files in %files section why not simply do:
   %{_javadir}/%{name}
 * You mix RPM_BUILD_ROOT and buildroot


But I'd say the package looks very good otherwise and with few minor
modifications we'll have freemind in Fedora. (yay!)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.