[Bug 225698] Merge Review: dmidecode

bugzilla at redhat.com bugzilla at redhat.com
Thu Nov 11 06:32:49 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225698

--- Comment #14 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2010-11-11 01:32:48 EST ---
Thanks for the update!

(In reply to comment #13)
> > > 
> > > * The release tag is a mess. Can we continue with the usual convention?:
> > > 2%{?dist} [1]
> 
> This appears to be the case in the latest spec:
> 
> Version:        2.10
> Release:        2%{?dist}
> Epoch:          1
> 
> (or maybe I'm misunderstanding you ...)
> 

It used to be
  Release: %(R="$Revision: 1.36 $"; RR="${R##: }"; echo ${RR%%?})%{?dist}.1

Now it is good, except your %changelog says it should be 3 instead of 2.

There are 2 more minor issues, then we can approve the package:
1- You use ${buildroot} at 2 places. These should be %{buildroot}. The former
is not defined.
2- Please give Source0 with full URL, using %{name}-%{version}. i.e.

http://download.savannah.gnu.org/releases/%{name}/%{name}-%{version}.tar.bz2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the package-review mailing list