[Bug 647076] Review Request: jackbeat - audio sequencer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647076

Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review?

--- Comment #15 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2010-11-11 02:23:21 EST ---
I started the review on this package. It needs a little bit of work:

- rpmlint says:
   jackbeat.x86_64: W: spelling-error %description -l en_US resized -> resined,
resided, re sized
   jackbeat.x86_64: W: spelling-error %description -l en_US jackeq -> jacket,
jacked, jack eq
   jackbeat.x86_64: W: no-manual-page-for-binary jackbeat
These can be ignored.

- koji rawhide build is fine
   http://koji.fedoraproject.org/koji/taskinfo?taskID=2594483

* src/core/pa_ringbuffer* are licensed MIT, src/gui/phat/phatrange* are
licensed LPGLv2+. The rest is GPLv2+
Thus the license tag should be "GPLv2+ and MIT and LGPLv2+". See
   http://fedoraproject.org/wiki/Licensing#Good_Licenses

* Macro consistency: You use %{buildroot} ${RPM_BUILD_ROOT} and $RPM_BUILD_ROOT
all at once. Stick to one.

* Scriptlets are not use properly. See
   http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
especially the "desktop-database" section.

! It would be better if you install the icon in
/usr/share/icons/hicolor/scalable/apps/ . This is not a requirement though.
/usr/share/pixmaps is used usually by old stuff. Note that if you do this, you
change this then you need to add the necessary scriptlets. See "icon cache"
section in the above link. Also you would need to Require: hicolor-icon-theme

* MimeType entry in the .desktop file should end with a semicolon. You can
validate your desktop file by running
   $ desktop-file-validate jackbeat.desktop

* One problem that I noticed with this software is, it doesn't stay connected
with jack. it kills jackd sometimes. Do you see this behavior?


I see that you started helping other people with packaging and reviewing, which
is very good (We usually ask the potential contributors to do unofficial
reviews to test their ability to follow the guidelines). By the way, could you
tell me your FAS username?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.