[Bug 649662] Review Request: python-tilecache - A web map tile caching system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=649662

--- Comment #13 from Michel Alexandre Salim <fedora at michelsylvain.info> 2010-11-11 05:39:03 EST ---
All looks good. APPROVED -- please make a request in the Fedora Accounts System
to join the packager group and I'll approve it.

A couple of small changes that you'd need to make:

(1) the file TileCache/Caches/S3.py is actually MIT-licensed, not BSD. It's
noted in LICENSE.txt and I verified it in the source header.

Could you change the License field to "BSD and MIT" and put a comment above
that line to that effect? e.g. "# TileCache/Caches/S3.py is MIT-licensed"

(2) The MD5 checksums don't match (see full review below). On the other hand
doing a recursive diff on both downloads show that both are identical. And the
file you bundle is marginally smaller (65616 vs 68705). When submitting, could
you replace the file with freshly-downloaded source?

(3) from the Koji logs you supply, are you targeting EPEL-6 as well? In which
case please re-add the %clean section; RHEL 6 is based on Fedora 12

(4) there is a test suite that you're not using. See attached patch. You can
probably still ship the test suite in the documentation as it's a good example
of how to use TileCache.

Ping me at salimma at fedoraproject.org if you have any question in the future or
need more packages reviewed; and please add me to the Cc: in the next several
packages you maintain.

Full review:
#+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n)

* TODO Review [75%]
** DONE Names [2/2]
*** DONE Package name
*** DONE Spec name
** DONE Meets
[[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
** FAIL source files match upstream
   - bundled:  1a5772e5d71b7463742060ccc3c49f1f
   - upstream: ff0153452a9e88a8d00405fb58d689df
** TODO License [2/3]
*** DONE License is Fedora-approved
*** FAIL License field accurate
    - please note in license field that TileCache/Caches/S3.py
*** DONE License included iff packaged by upstream
** DONE rpmlint [2/2]
*** DONE on src.rpm
*** DONE on x86_64.rpm
** DONE Language & locale [3/3]
*** DONE Spec in US English
*** DONE Spec legible
*** N/A Use %find_lang to handle locale files
** DONE Build [3/3]
*** DONE Koji results
*** DONE BRs complete
*** DONE Directory ownership
** DONE Spec inspection [8/8]
*** DONE No duplicate files
*** DONE File permissions
*** DONE Filenames must be UTF-8
*** DONE no BuildRoot
([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if
targeting EPEL5]])
*** DONE Has %clean section
    (except F-13+:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean)
*** DONE %buildroot cleaned on %install
*** DONE Macro usage consistent
*** DONE Documentation [2/2]
**** N/A If large docs, separate -doc
**** DONE %doc files are non-essential

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.