[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python >= 2.6

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651227

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Thomas Spura <tomspur at fedoraproject.org> 2010-11-11 07:07:07 EST ---
Issues:

- Where do you have the sources from?
  You need to write the commands down, how you generated that tar ball, when
using git or somthing (don't find the guideline link atm...)

- Please don't menition python 2.6 or versions like that, it's a XMPP library
and that's it :)
  A user doesn't need to know something about the python version, only that it
works with the python version currently in fedora ;-)
  Please delete that from summary and description

- Please add acomment, that you didn't add python3-dns yet to Requires

- %files section:
  When you are more explicit with %files, you know when builing an egg failed:
e.g.:
%{python3_sitelib}/sleekxmpp/
%{python3_sitelib}/sleekxmpp-*.egg-info

- INSTALL is not a doc. It helps you to install it, but it's not a documentary
for the user later on.

Rest looks ok so far:
- no *.la
- no libs
- name ok


Didn't look for the license yet, will do that, when the issues are gone.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.