[Bug 651227] Review Request: python-sleekxmpp - Flexible XMPP client/component/server library for Python

bugzilla at redhat.com bugzilla at redhat.com
Thu Nov 11 15:15:19 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=651227

Florent Le Coz <louiz at louiz.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |python-sleekxmpp - Flexible |python-sleekxmpp - Flexible
                   |XMPP                        |XMPP
                   |client/component/server     |client/component/server
                   |library for Python >= 2.6   |library for Python

--- Comment #6 from Florent Le Coz <louiz at louiz.org> 2010-11-11 10:15:18 EST ---
(In reply to comment #5)
> Issues:
> 
> - Where do you have the sources from?
>   You need to write the commands down, how you generated that tar ball, when
> using git or somthing (don't find the guideline link atm...)
> 
It's just a temporary thing. SleekXMPP will be hosted on pypi after the final
release. The current problem is that github generates a temporary URL only when
browsing the download page. So I hosted it myself, but in the futur it should
be OK directly from upstream.
Anyway, fixed in the spec.

> - Please don't menition python 2.6 or versions like that, it's a XMPP library
> and that's it :)
>   A user doesn't need to know something about the python version, only that it
> works with the python version currently in fedora ;-)
>   Please delete that from summary and description
> 
Ok, done

> - Please add acomment, that you didn't add python3-dns yet to Requires
> 
Done

> - %files section:
>   When you are more explicit with %files, you know when builing an egg failed:
> e.g.:
> %{python3_sitelib}/sleekxmpp/
> %{python3_sitelib}/sleekxmpp-*.egg-info
> 
Done

> - INSTALL is not a doc. It helps you to install it, but it's not a documentary
> for the user later on.
>
Done

Spec URL: http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp.spec
SRPM URL:
http://louizatakk.fedorapeople.org/rpm/python-sleekxmpp-1.0-0.4.beta2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list