[Bug 649939] Review Request: loook - search tool for OpenOffice.org documents

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=649939

--- Comment #5 from Hans de Goede <hdegoede at redhat.com> 2010-11-11 10:36:19 EST ---
Hi,

Sorry to be a bit pedantic, but I would like to see one more revision.

This bit:

install -Dpm 0644 %{name}.desktop
$RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop

desktop-file-install --delete-original  \
        --dir $RPM_BUILD_ROOT%{_datadir}/applications   \
        --remove-category Application \
        $RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop

Is a bit weird, first you install it using install, then you install it *again*
using desktop-file-install. Instead you can simply do:

desktop-file-install --dir $RPM_BUILD_ROOT%{_datadir}/applications   \
        %{name}.desktop

Note:
1) The --delete-original is gone now, as it is no longer needed
2) The --remove-category Application is gone (it is only needed
   for older .desktop files which wrongly contain Application in
   their Categories=...; list)
3) It may be necessary to first create
   $RPM_BUILD_ROOT%{_datadir}/applications
4) Adding a .desktop file with a patch is a bit unconventional. It is fine
   but usually people just include the file as

Source1: %{name}.desktop

   And the install command becomes:

desktop-file-install --dir $RPM_BUILD_ROOT%{_datadir}/applications %{SOURCE1}

Regards,

Hans

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.