[Bug 650992] Review Request: emacs-auto-complete - Intelligent auto-complete extension for GNU Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=650992

Arun SAG <sagarun at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Arun SAG <sagarun at gmail.com> 2010-11-11 12:36:14 EST ---
[+] OK
[X] NOT OKAY
[-] NA


[+] Package meets naming and packaging guidelines
[+] Spec file matches base package name.
[+] Spec has consistant macro usage.
[+] Meets Packaging Guidelines.
[+] License
[+] License field in spec matches
[+] License file included in package
[+] Spec in American English
[+] Spec is legible.
[+] Sources match upstream md5sum:
[zer0c00l at gnubox ~]$ md5sum auto-complete-1.3.tar.bz2 
8c095a7ad5f4848e3ca95000d81e86a8  auto-complete-1.3.tar.bz2

[-] Package needs ExcludeArch
[+] BuildRequires correct
[-] Spec handles locales/find_lang
[-] Package is relocatable and has a reason to be.
[+] Package has %defattr and permissions on files is good.
[+] Package has a correct %clean section.
[-] Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[+] Package is code or permissible content.
[-] Doc subpackage needed/used.
[-] Packages %doc files don't affect runtime.

[-] Headers/static libs in -devel subpackage.
[-] Spec has needed ldconfig in post and postun
[-] .pc files in -devel subpackage/requires pkgconfig
[-] .so files in -devel subpackage.
[-] -devel package Requires: %{name} = %{version}-%{release}
[-] .la files are removed.

[-] Package is a GUI app and has a .desktop file

[+] Package compiles and builds on at least one arch.
[+] Package has no duplicate files in %files.
[+] Package doesn't own any directories other packages own.
[+] Package owns all the directories it creates.

[?] No rpmlint output : 
[zer0c00l at gnubox transmission-scripts]$ rpmlint
~/rpmbuild/RPMS/noarch/emacs-auto-complete-1.3-1.fc13.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[zer0c00l at gnubox transmission-scripts]$ rpmlint
~/rpmbuild/RPMS/noarch/emacs-auto-complete-el-1.3-1.fc13.noarch.rpm 
emacs-auto-complete-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis,
Lisp, Elise
emacs-auto-complete-el.noarch: W: spelling-error %description -l en_US elisp ->
lisp, e lisp, Elise
emacs-auto-complete-el.noarch: E: description-line-too-long C This package
contains the elisp source files for Auto Complete Mode under GNU Emacs. You
emacs-auto-complete-el.noarch: E: description-line-too-long C do not need to
install this package to run Auto Complete Mode. Install the emacs-auto-complete
emacs-auto-complete-el.noarch: W: no-documentation
1 packages and 0 specfiles checked; 2 errors, 3 warnings.


SHOULD Items:

[+] Should build in mock.
[+] Should build on all supported archs
[+] Should function as described.
[-] Should have sane scriptlets.
[+] Should have subpackages require base package with fully versioned depend.
[+] Should have dist tag
[+] Should package latest version
[+] check for outstanding bugs on package. (For core merge reviews)

Issues:

1.Everything is good here. Please change fix the description before pushing it
to koji. Also please speak with the upstream to include License files.


XXX APPROVED XXX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.