[Bug 652533] Review Request: postgresql-pgrouting - Provides routing functionality to PostGIS/PostgreSQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652533

--- Comment #3 from Michel Alexandre Salim <fedora at michelsylvain.info> 2010-11-12 14:15:05 EST ---
#+TODO: TODO(t) WAIT(w@/!) FAIL(f@) | DONE(d) N/A(n)

* TODO Review [75%]
** DONE Names [2/2]
*** DONE Package name
    pgRouting or pgrouting would be good package names too, but I see
    their bundled Debian configuration uses postgres-X.Y-pgrouting so
    I guess postgres-pgrouting is a good choice.
*** DONE Spec name
** DONE Meets
[[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
** DONE source files match upstream
   $ md5sum pgRouting-1.03.tgz ../SOURCES/pgRouting-1.03.tgz 
   ee700d18a984b8fd78c1a739ca078683  pgRouting-1.03.tgz
   ee700d18a984b8fd78c1a739ca078683  ../SOURCES/pgRouting-1.03.tgz

** TODO License [2/3]
*** DONE License is Fedora-approved
*** FAIL License field accurate
    Should be "GPLv2+ and Boost"; make a note that shooting_star* are under the
    latter license
*** DONE License included iff packaged by upstream
** DONE rpmlint [2/2]
*** DONE on src.rpm
*** DONE on x86_64.rpm
** DONE Language & locale [3/3]
*** DONE Spec in US English
*** DONE Spec legible
*** N/A Use %find_lang to handle locale files
** DONE Build [3/3]
*** DONE Koji results
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2597933
*** DONE BRs complete
*** DONE Directory ownership
** TODO Spec inspection [8/9]
*** N/A ldconfig for libraries
*** DONE No duplicate files
*** DONE File permissions
*** DONE Filenames must be UTF-8
*** DONE no BuildRoot
([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if
targeting EPEL5]])
*** DONE Has %clean section
    (except F-13+:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean)
*** DONE %buildroot cleaned on %install
*** FAIL Macro usage consistent
    see cmake guidelines:
    http://fedoraproject.org/wiki/Packaging/cmake
    - no need to test for %{?_lib} == lib64; the cmake macro does that
    - no need to override CMAKE_INSTALL_PREFIX, likewise done by the macro
    - please use VERBOSE=1 and %{?_smp_mflags}. The former makes sure
      the build logs are detailed (useful to see, e.g., if the
      compiler flags are being used properly). The latter speeds up
      the build (the build servers use -j 16, normally).

      If the build cannot be parallelized, comment out the %{?_smp_mflags}
      part, put a comment and notify upstream.
    - even with VERBOSE=1 it does not look like CFLAGS and CXXFLAGS are
      being used. See attached patch -- looks like the cmake configuration
      sets CFLAGS and CXXFLAGS regardless of what the user passed in.

      Please report the problem upstream once we're done with the review.
    - no need to BuildRequires gcc-c++:
      see http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

*** DONE Documentation [2/2]
**** N/A If large docs, separate -doc
**** DONE %doc files are non-essential

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.