[Bug 541463] Review Request: garmin-sync - Download data from Garmin fitness computers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541463

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+

--- Comment #2 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-14 11:33:55 EST ---
Not sure why nobody has looked at this yet; there's not much to it.  It still
builds OK and installs on rawhide.  I haven't any hardware I could use to test
it but I suspect that given that upstream is dead and nothing has changed, it
will work as well as it ever did.

For modern Fedora there are a few things you can remove: BuildRoot, %clean and
the first line of %install.

Otherwise rpmlint just complains about the lack of a manpage.  That's always
nice to fix but it's not essential.

APPROVED

* source files match upstream.  sha256sum:
  efc4e1410d22a50ebe58e09d291ee0e46254cb6e0f367f2e3b569df848ff5dfb
   garmin-sync-0.3.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   garmin-sync = 0.3-3.fc15
  =
   /usr/bin/env  
   pyusb  

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.