[Bug 623606] Review Request: gxneur - GTK front-end for X Neural Switcher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=623606

Golo Fuchert <packages at golotop.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |packages at golotop.de

Bug 623606 depends on bug 623604, which changed state.

Bug 623604 Summary: Review Request: xneur - X Neural Switcher
https://bugzilla.redhat.com/show_bug.cgi?id=623604

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

--- Comment #2 from Golo Fuchert <packages at golotop.de> 2010-11-14 16:18:20 EST ---
Hi, I have a few comments on this package. Please note that I am fairly new
here and so some points may be more like questions than real issues.

- I start with the most unimportant one. I have the feeling that most Fedora
packagers prefer one line for every single build dependency in order to make
the spec file more legible. However, I did not find anything specific about
this in the guidelines and so probably this is up to you.

- I think you were not accurate enough with the license tags. The code in src/
states GPLv2+ (not just GPLv2) as license and some of the code in m4/ seems to
be licensed under the LGPL. You find for example in the progtest.m4:
  * dnl Please note that the actual code of the GNU gettext library is covered
  * dnl by the GNU Library General Public License, and the rest of the GNU
  * dnl gettext package package is covered by the GNU General Public License.
Maybe my understanding is not correct but if parts of this code are contained
then it has to be mentioned in the License tag of the spec file.

- This point may just show that I still have to learn a lot, but what is the
code in m4/ good for? Are there really parts of the code of libtool or gettext
included and if so, is this really allowed since Fedora has devel packages for
those? (As I said, this comment may just show my lack of understanding. In that
case I apologize for it and would be pleased to learn what this code is doing
there.)

- I think the build dependencies are not yet fully correct.
I was not able to build the package without adding "GConf2-devel" as a build
dependency and some are not necessary since others depend on them:
  * libglade2-devel requires gtk2-devel which in turn requires autoconf and 
    automake

- It seems as if you accidentally forgot to update the desktop database after
installing a .desktop file:

%post
update-desktop-database &> /dev/null || :
%postun
update-desktop-database &> /dev/null || :

- I think the description maybe a bit problematic. The Packaging Guidelines
state that a phrasing like "a program like ..." should be avoided since people
might understand you wrong (or might _want_ to understand you wrong) when it
comes to trademarks. For more information see:
http://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description
Now I am not really sure if Punto Switcher is a trademark or not, but maybe it
would be better just to describe what the software is doing? Maybe I am wrong
here, but it's better to ask those questions _before_ getting in trouble. ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.