[Bug 623606] Review Request: gxneur - GTK front-end for X Neural Switcher

bugzilla at redhat.com bugzilla at redhat.com
Sun Nov 14 22:09:17 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=623606

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de

--- Comment #3 from Martin Gieseking <martin.gieseking at uos.de> 2010-11-14 17:09:16 EST ---
(In reply to comment #2)
> - I start with the most unimportant one. I have the feeling that most Fedora
> packagers prefer one line for every single build dependency in order to make
> the spec file more legible. However, I did not find anything specific about
> this in the guidelines and so probably this is up to you.

Yes, this is up to the packager and isn't a blocker here.


> - I think you were not accurate enough with the license tags. The code in src/
> states GPLv2+ (not just GPLv2) as license and some of the code in m4/ seems to
> be licensed under the LGPL.

The License field must reflect the license of the *binary* package. Thus, only
packaged files have to be considered when determining the license. The m4 files
are merely required together with the autotools during configuration. So GPLv2+
is the correct tag for this package.


> %post
> update-desktop-database &> /dev/null || :
> %postun
> update-desktop-database &> /dev/null || :

That's not necessary here. Calling desktop-file-install or
desktop-file-validate in %install is sufficient. You usually have to refresh
the desktop database only if the desktop file contains a MimeType field.

> - I think the description maybe a bit problematic. The Packaging Guidelines
> state that a phrasing like "a program like ..." should be avoided since people
> might understand you wrong (or might _want_ to understand you wrong) when it
> comes to trademarks. 

I agree -- a more detailed description would be nice. Without further
investigation, I don't really understand what the program does.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list