[Bug 579662] Review Request: emacs-lookup - Search Interface with Electronic Dictionaries for Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579662

Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Jens Petersen <petersen at redhat.com> 2010-11-15 01:52:27 EST ---
Thanks.  Here is the review:

 +:ok, !:needs attention,  NA: not applicable

MUST Items:
[+] MUST: rpmlint output:
emacs-lookup.src: W: no-cleaning-of-buildroot %clean
emacs-lookup.src: W: no-buildroot-tag
emacs-lookup.src: W: no-%clean-section
emacs-lookup-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis, Lisp,
Elise
emacs-lookup-el.noarch: W: spelling-error %description -l en_US elisp -> lisp,
e lisp, Elise
emacs-lookup-el.noarch: W: no-documentation

[+] MUST: The package must be named according to the Package Naming Guidelines
[+] MUST: The spec file name must match base package %{name}
[+] MUST: The package must meet the Packaging Guidelines.

packaging follows Packaging:Emacs guidelines

[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines

source files have gpl headers

[+] MUST: The License field in the package spec file must match the actual
license.
[!] MUST: include license files in %doc if included in source

Please add the COPYING file

[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release

5f66507835f8636bd3a91243d0760a46  lookup-1.4.1.tar.gz

[+] MUST: must successfully compile and build into binary rpms on one main arch
[NA] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations
[NA] MUST: packages with shared library files in the dynamic linker's default
paths, must call ldconfig in %post and %postun.
[NA] MUST: Packages must NOT bundle copies of system libraries.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review
[+] MUST: A package must own all directories that it creates, or require a
package which does create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing
(except license files if necessary).
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must consistently use macros
[+] MUST: The package must contain code, or permissable content.
[NA] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[NA] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: If a package has library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
[NA] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 
[NA] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[NA] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

SHOULD Items:
[NA] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[!] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.

Might be nice to add later at some point, if possible.

[+] SHOULD: The reviewer should test that the package builds in mock.

http://koji.fedoraproject.org/koji/taskinfo?taskID=2601192

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.

Please be sure to include the COPYING file before importing to SCM.

I think it is better also to convert NEWS to utf8, though not sure
if the guidelines insist on that.

Package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.