[Bug 527462] Review Request: gmpy - Python interface to GMP

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527462

--- Comment #28 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-11-15 08:14:02 EST ---
rpmlint is now at:

gmpy.src: W: spelling-error %description -l en_US multiprecision ->
multiprocessing, multiprocessor, imprecision
gmpy.src: W: invalid-url Source0:
http://gmpy.googlecode.com/files/gmpy-1.13.zip HTTP Error 404: Not Found
gmpy.x86_64: W: spelling-error %description -l en_US multiprecision ->
multiprocessing, multiprocessor, imprecision
3 packages and 0 specfiles checked; 0 errors, 3 warnings.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- License header exists only in src/gmpy.c which states LGPLv2+, thus the
intention of the author can be considered clear.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
cf6ef1c3beda3ae291da9bdad36d4e9e  gmpy-1.13.zip
cf6ef1c3beda3ae291da9bdad36d4e9e  ../SOURCES/gmpy-1.13.zip

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSWORK
- Add the license, lgpl-2.1.txt, to %doc.

MUST: Header files must be in a -devel package.N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK


So, in summary, what you need to is change
 %doc README doc/
to
 %doc README lgpl-2.1.txt doc/*
to fix the two issues. After that, this package is good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.