[Bug 548795] Review Request: belier - Generates scripts allowing you to chain many ssh connections

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548795

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?

--- Comment #10 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-15 20:01:53 EST ---
"bump" doesn't really have any effect here; this isn't a web forum, and nobody
was signed on to review your package.  I'm looking over all of the old tickets
and see that this one seems to be quite fine.

Builds fine on rawhide and rpmlint has only this to say:
  belier.noarch: W: no-manual-page-for-binary bel
A manpage would be nice but is not essential.

There are some bits of your spec which are not needed in Fedora (or EPEL6):
BuildRoot, %clean and the first line of %install.  You can remove them if you
like.

* source files match upstream.  sha256sum:
  9fe20425d0e061112c38288ce105bc7905a55c22836e801b310541b56e4df409
   belier-1.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   belier = 1.2-3.fc15
  =
   /usr/bin/python  
   expect  
   gettext  
   python(abi) = 2.7

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.