[Bug 548795] Review Request: belier - Generates scripts allowing you to chain many ssh connections

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 16 10:45:19 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548795

--- Comment #12 from Florent Le Coz <louiz at louiz.org> 2010-11-16 05:45:18 EST ---
(In reply to comment #10)
> "bump" doesn't really have any effect here; this isn't a web forum, and nobody
> was signed on to review your package.
Ok, sorry about that.

> There are some bits of your spec which are not needed in Fedora (or EPEL6):
> BuildRoot, %clean and the first line of %install.  You can remove them if you
> like.
I left them in the spec file because that's how I usually do and how I see
other spec files. Moreover, rpmlint complains about the missing sections if I
remove them.
So, since I find them clearer, I'll keep them in place.

> APPROVED

Thank you for the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list