[Bug 653378] Review Request: gtk-theme-engine-clearlooks - Clearlooks GTK+ theme engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653378

Matthias Clasen <mclasen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mclasen at redhat.com
         AssignedTo|nobody at fedoraproject.org    |mclasen at redhat.com

--- Comment #1 from Matthias Clasen <mclasen at redhat.com> 2010-11-16 08:55:16 EST ---
builds fine in mock.
rpmlint output:

$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/gtk-theme-engine-clearlooks-*.rpm
gtk-theme-engine-clearlooks.src:13: W: unversioned-explicit-obsoletes
gtk3-engines
gtk-theme-engine-clearlooks.src: W: no-cleaning-of-buildroot %install
gtk-theme-engine-clearlooks.src: W: no-cleaning-of-buildroot %clean
gtk-theme-engine-clearlooks.src: W: no-buildroot-tag
gtk-theme-engine-clearlooks.src: W: no-%clean-section
gtk-theme-engine-clearlooks.x86_64: W: obsolete-not-provided gtk3-engines
gtk-theme-engine-clearlooks.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/pkgconfig/gtk-theme-engine-clearlooks-3.pc
3 packages and 0 specfiles checked; 0 errors, 7 warnings.

The obsoletes is questionable anyway, in my opinion. We should leave it out.
The .pc file indeed needs to go into a sucky, single-file -devel package. I'm
going to advocate for dropping it from the upstream tarball, since it is
useless.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.