[Bug 499992] Review Request: mingw32-webkitgtk - MinGW Windows web content engine library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=499992

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?

--- Comment #16 from Jason Tibbitts <tibbs at math.uh.edu> 2010-11-16 10:54:26 EST ---
This is a huge build, and the debuginfo package is hilarious; one of the debug
files is over a gigabyte.  Fortunately it compresses pretty well.

Note that Fedora doesn't need BuildRoot:, %clean or the first line of %install.

I think the main package %description probably needs mention of MinGW
somewhere.

The license information seems to be missing.  The regular webkitgtk package
puts it in the -doc subpackage, which is actually a guideline violation, but
you seem to drop the -doc package altogether so it doesn't get in at all.

* source files match upstream.  sha256sum:
  c9bdd5eb544d9447dbfa117cac2c925b6d09091a6a9798c71f2d2e6d5ab542f9
   webkit-1.3.6.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
? description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
X license text not included in package.
* version packaged is the same as the native Fedora version.
* package is noarch.
* BuildRequires are proper.
* compiler flags are appropriate.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* special mingw32 dependency generators are used.
* final provides and requires are sane:
  mingw32-webkitgtk-1.3.6-1.fc15.noarch.rpm
   mingw32(libwebkitgtk-1.0-0.dll)  
   mingw32-webkitgtk = 1.3.6-1.fc15
  =
   mingw32-filesystem >= 63
   mingw32-runtime  
   mingw32(kernel32.dll)  
   mingw32(libatk-1.0-0.dll)  
   mingw32(libcairo-2.dll)  
   mingw32(libenchant.dll)  
   mingw32(libgailutil-18.dll)  
   mingw32(libgcc_s_sjlj-1.dll)  
   mingw32(libgdk_pixbuf-2.0-0.dll)  
   mingw32(libgdk-win32-2.0-0.dll)  
   mingw32(libgio-2.0-0.dll)  
   mingw32(libglib-2.0-0.dll)  
   mingw32(libgmodule-2.0-0.dll)  
   mingw32(libgnutls-26.dll)  
   mingw32(libgobject-2.0-0.dll)  
   mingw32(libgthread-2.0-0.dll)  
   mingw32(libgtk-win32-2.0-0.dll)  
   mingw32(libjpeg-7.dll)  
   mingw32(libpango-1.0-0.dll)  
   mingw32(libpangocairo-1.0-0.dll)  
   mingw32(libpng14-14.dll)  
   mingw32(libsoup-2.4-1.dll)  
   mingw32(libsqlite3-0.dll)  
   mingw32(libstdc++-6.dll)  
   mingw32(libwebkitgtk-1.0-0.dll)  
   mingw32(libxml2-2.dll)  
   mingw32(libxslt-1.dll)  
   mingw32(msvcrt.dll)  
   mingw32(ole32.dll)  
   mingw32(pthreadgc2.dll)  
   mingw32(user32.dll)  

  mingw32-webkitgtk-static-1.3.6-1.fc15.noarch.rpm
   mingw32-webkitgtk-static = 1.3.6-1.fc15
  =
   mingw32-webkitgtk = 1.3.6-1.fc15
   mingw32-filesystem >= 63
   mingw32-runtime  

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* static libraries are in a separate -static subpackage.
* .dll and .def files in _mingw32_bindir
* .dll.a and .la files in _mingw32_libdir
* dll files are listed explicitly in %files.
* libraries and executables are stripped properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.